Use the maximum pipe size if this is available. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@marcelm This is now ready for review. |
Collaborator
|
Thanks for this and also the detailed analysis in #35! This is a really nice improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
This is dependent on the PipedCompressionReader PR.
F_SETPIPE_SZ and F_GETPIPE_SZ are set with
getattrto the fcntl module. As of Python 3.10 these constants should be available in that code by default (if my PR to cpython gets merged). By setting it this way, backwards-compatibility can be guaranteed.As of python 3.10 it should also be possible to set the pipesize directly in subprocess.Popen. But it will take at least 6 years for all versions below python 3.10 not to be supported anymore.