Skip to content

Conversation

@davidhewitt
Copy link
Contributor

Implements automatic detection of terminals for console colors.

@davidhewitt davidhewitt requested a review from cetra3 November 2, 2025 20:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 78.99160% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/exporters/console.rs 74.22% 13 Missing and 12 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cetra3 cetra3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wondering if this can be controlled by an env var as well? Good first step though

@davidhewitt
Copy link
Contributor Author

Yes, the whole lot of configs need better sync with env vars 👍

@davidhewitt davidhewitt merged commit d8d71c6 into main Nov 4, 2025
7 checks passed
@davidhewitt davidhewitt deleted the dh/console-colors branch November 4, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants