Skip to content

Conversation

@marc-pydantic
Copy link

(currently opening this to get a CI run)

The underlying opentelemetry should at some point migrate from 0.30 to 0.31, if only to because some transitive dependencies have moved on, e.g. prost.

The tracing-opentelemetry crate had some unforced changes going from 0.30 to 0.31 (opentelemetry version, NOT tracing-opentelemetry, which confusingly is a one minor version ahead).

This branch is using a fork of tracing-opentelemetry that has manually seen its opentelemetry updated.

@marc-pydantic marc-pydantic requested a review from cetra3 December 1, 2025 14:36
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Cargo.toml Outdated
tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
tracing-opentelemetry = "0.31"
tracing-opentelemetry = { git = "https://github.com/marc-pydantic/tracing-opentelemetry", branch = "marc/opentelemetry-0.31" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier if you move this in as a module to this crate?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say equally different. I assume this is a stopgap measure for now.

@cetra3
Copy link
Contributor

cetra3 commented Dec 1, 2025

This may not work with the greater ecosystem as well, which sucks. There are some other crates we are using that depend on tracing-opentelemetry like axum-tracing-opentelemetry and reqwest-tracing

@davidhewitt
Copy link
Contributor

Can we just update to tracing-opentelemetry 0.32?

@marc-pydantic
Copy link
Author

Can we just update to tracing-opentelemetry 0.32?

Not straight away, as the underlying API has changed significantly in the meantime, for reasons I don't understand yet. After spending a few fruitless hours trying to replicate the old logfire behavior with the new API, I made a fork of the unaltered version of tracing-opentelemetry and simply put in opentelemetry 0.31 instead. It "just worked", showing there was no need to do a breaking change before said version bump.

The breaking change occurred here: tokio-rs/tracing-opentelemetry#202 -- you'll see that others have also felt the changes. There's already some work in undoing some of the damage (tokio-rs/tracing-opentelemetry#234), it might be that eventually a more backwards-compatible version of tracing-opentelemetry comes out again, which we could then use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants