-
Notifications
You must be signed in to change notification settings - Fork 6
Move to opentelemetry 0.31.
#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Cargo.toml
Outdated
| tracing = "0.1" | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | ||
| tracing-opentelemetry = "0.31" | ||
| tracing-opentelemetry = { git = "https://github.com/marc-pydantic/tracing-opentelemetry", branch = "marc/opentelemetry-0.31" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easier if you move this in as a module to this crate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say equally different. I assume this is a stopgap measure for now.
|
This may not work with the greater ecosystem as well, which sucks. There are some other crates we are using that depend on |
|
Can we just update to |
Not straight away, as the underlying API has changed significantly in the meantime, for reasons I don't understand yet. After spending a few fruitless hours trying to replicate the old The breaking change occurred here: tokio-rs/tracing-opentelemetry#202 -- you'll see that others have also felt the changes. There's already some work in undoing some of the damage (tokio-rs/tracing-opentelemetry#234), it might be that eventually a more backwards-compatible version of |
(currently opening this to get a CI run)
The underlying
opentelemetryshould at some point migrate from0.30to0.31, if only to because some transitive dependencies have moved on, e.g.prost.The
tracing-opentelemetrycrate had some unforced changes going from0.30to0.31(opentelemetryversion, NOTtracing-opentelemetry, which confusingly is a one minor version ahead).This branch is using a fork of
tracing-opentelemetrythat has manually seen itsopentelemetryupdated.