Mark ambiguous run summary recommendations#1926
Open
snoopuppy582 wants to merge 2 commits into
Open
Conversation
Author
|
I pushed a small snapshot-spacing follow-up after CI. The test matrix was failing in Local checks after the follow-up:
|
Author
|
CI update after the snapshot-spacing follow-up:
This looks unrelated to this PR's CLI recommendation text/snapshot change. I tried to rerun the failed job, but GitHub requires repository admin rights for reruns on this workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
alexmojaki
reviewed
May 14, 2026
Comment on lines
+295
to
+297
| │ ☐ urllib* (need to install opentelemetry-instrumentation-urllib) │ | ||
| │ │ | ||
| │ * `urllib` may be detected even when your app does not use it directly; ignore these recommendations if they are not used by your code. │ |
Collaborator
There was a problem hiding this comment.
Suggested change
| │ ☐ urllib* (need to install opentelemetry-instrumentation-urllib) │ | |
| │ │ | |
| │ * `urllib` may be detected even when your app does not use it directly; ignore these recommendations if they are not used by your code. │ | |
| │ ☐ urllib [*] (need to install opentelemetry-instrumentation-urllib) │ | |
| │ │ | |
| │ [*] `urllib` may not actually be used by your app, in which case you can ignore this recommendation │ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1296
Summary
logfire runrecommendations (requests,sqlite3,urllib) with*.Tests
uv run pytest tests/test_cli.py::test_get_recommendation_texts tests/test_cli.py::test_get_recommendation_texts_marks_ambiguous_packages -quv run ruff check logfire/_internal/cli/run.py tests/test_cli.pyuv run ruff format --check logfire/_internal/cli/run.py tests/test_cli.pyNotes