Merged
Conversation
Deploying logfire-docs with
|
| Latest commit: |
466a216
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5352f567.logfire-docs.pages.dev |
| Branch Preview URL: | https://ci-pin-deps.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 10256 10256
Branches 1399 1399
=========================================
Hits 10256 10256 ☔ View full report in Codecov by Sentry. |
Member
|
Since we are doing this, it would be good to have dependabot as well. |
Member
|
The previous approach had the pro argument that we are faster to find out about incompatibilities caused by the optional dependencies. Which was the reason we made it that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also use the new dev dependency groups in uv.
@alexmojaki @Kludex I think you’re both off today, and I need to get CI passing, so I’m going to merge this to pin dependencies and thereby get tests passing.
As I said on slack, I think pinning deps in CI is the best route anyway, but happy to discuss other routes when your back, you can consider this a temporary fix until we discuss next week.