Conversation
Deploying logfire-docs with
|
| Latest commit: |
7d26743
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cbcdb580.logfire-docs.pages.dev |
| Branch Preview URL: | https://test-with-upgraded-deps.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 10448 10448
Branches 1430 1430
=========================================
Hits 10448 10448 ☔ View full report in Codecov by Sentry. |
| name: test on Python ${{ matrix.python-version }} and pydantic ${{ matrix.pydantic-version }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||
| pydantic-version: ['main'] | ||
| include: | ||
| - python-version: '3.12' | ||
| pydantic-version: '2.4' | ||
| - python-version: '3.12' | ||
| pydantic-version: '2.5' | ||
| - python-version: '3.12' | ||
| pydantic-version: '2.6' | ||
| - python-version: '3.12' | ||
| pydantic-version: '2.7' | ||
| - python-version: '3.12' | ||
| pydantic-version: '2.8' | ||
| - python-version: '3.12' | ||
| pydantic-version: '2.9' |
There was a problem hiding this comment.
Why do we do this only with Pydantic?
There was a problem hiding this comment.
I think we will want a matrix for other deps too but it doesn't need to be a first step. We're still using the latest version of everything.
I also think that having this full matrix here means that regular CI only needs 2.4 and the latest release (pinned) and anything else needed for coverage (eventually v1 when some form of that works) so that it can run quickly and cheaply. Not a blocker though.
There was a problem hiding this comment.
Wouldn't it make sense to just test 2.4 and main on the daily CI, and leave all of these for the PR tests?
There was a problem hiding this comment.
No, the daily CI is a good place to put things that take longer that we don't want to wait for to merge a PR.
|
Seems like it's working because tests are already failing due to another OTEL release. The assertion diffs look related to open-telemetry/opentelemetry-python#4251 |
3 participants
FIxes #580