ENH: TrueFX tick datareader #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas_datareader/truefx.py
Outdated
Contributor
Author
There was a problem hiding this comment.
Uncomment this to have a short processing time.
Contributor
Author
|
Processing is so long that it leads to Travis CI build error |
Contributor
Author
|
Python 2.6 Travis build is failing. Others Python versions seems to be ok. Any idea why it's failing with 2.6 ? |
| df = pd.read_csv(zfile, names=['Symbol', 'Date', 'Bid', 'Ask']) | ||
|
|
||
| df['Date'] = pd.to_datetime(df['Date'], format='%Y%m%d %H:%M:%S.%f') | ||
| df = df.set_index('Date') |
Contributor
Author
There was a problem hiding this comment.
Caution: Date columns have non unique values
df = df.set_index('Date', verify_integrity=True)
should raises error
we might make Date unique (adding a quantum of 1 microsecond or 1 nanosecond)
Contributor
Author
|
Direct download is not available anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #153