License file to be included into metadata dir#173
Merged
Conversation
matthewwardrop
force-pushed
the
master
branch
2 times, most recently
from
b07ba3f to
48fd2e4
Compare
Collaborator
|
Thanks for your patch! This does not seem to be an issue with modern versions of setuptools (this is done automatically now: pypa/setuptools#1536); and I have confirmed that everything is working. Nevertheless, I see no harm in explicitly calling this out in the metadata, so I'll merge in this patch in anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Please, add the LICENSE.txt file into metadata dir of your package (e.g. by accepting this pull request).
I understand you probably hate software laws etc., so I will be short.
You are using BSD 2-Clause license. It says also: "Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer." But your whole package distributed on PyPI.org does not contain even one. This short change will add the file LICENSE.txt (with text of BSD license) into metadata of your package (= into e.g. .../site-packages/patsy-0.5.1.dist-info/LICENSE.txt of your virtualenv). This way you are 100% clear and comply with your chosen license.
Thank you for your time and your work.
Pax et bonum.