#1621 optional decode timedelta #4071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
reviewed
May 19, 2020
| chunks, | ||
| drop_variables, | ||
| use_cftime, | ||
| decode_timedelta, |
Member
There was a problem hiding this comment.
In theory, it would be better organized to add this argument after decode_times, but for now what you have done here putting it at the end is a good choice to preserve backwards compatibility. I made a note about making most open_dataset arguments keyword only in #4080.
shoyer
approved these changes
May 19, 2020
Member
shoyer
left a comment
shoyer
left a comment
There was a problem hiding this comment.
Very nice -- looks great to me!
Thanks!
Member
|
Thank you @aurghs, I'm looking forward to more great PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releated to ticket #1621. Add
decode_timedeltakwargs in open_dataset,xr.open_datarray,xr.open_zarr,xr.decode_cf. If not passed explicitly the behaviour is not changed.xr.decode_cf.isort -rc . && black . && mypy . && flake8whats-new.rstfor all changes andapi.rstfor new API