silence the dask dataframe upstream-dev errors #4757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Jan 3, 2021
Collaborator
|
Thanks @keewis How should we think about changing the test code vs xfailing? IIUC the current test code should work, but doesn't because of the pandas issue. Would we expect to revert this after pandas fixes its issue? |
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Collaborator
Author
that's a good point. I'm really not sure: in this case we don't change the behavior of the test, but in general it would probably be better to xfail. |
Contributor
|
It's a bug in constructing an expected dataframe. Seems OK to change it and not revert once pandas fixes its behaviour. |
dcherian
approved these changes
Jan 3, 2021
max-sixty
approved these changes
Jan 4, 2021
Collaborator
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
in this case we don't change the behavior of the test
I see, SGTM
andersy005
approved these changes
Jan 4, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
to_dask_dataframetests fail on the upstream-dev CI because the behavior ofpandas.DataFramechanged (see pandas-dev/pandas#38645). For now we can silence these by computing alldaskarrays we pass topandas.DataFrame.isort . && black . && mypy . && flake8