Skip to content

Fix DataArray transpose inconsistent with Dataset Ellipsis usage #4767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
max-sixty merged 2 commits into from
Jan 5, 2021
Merged

Fix DataArray transpose inconsistent with Dataset Ellipsis usage #4767

max-sixty merged 2 commits into from
Jan 5, 2021

Conversation

@mesejo
Copy link
Contributor

@mesejo mesejo commented Jan 5, 2021 •
edited
Loading

@mesejo mesejo force-pushed the 4647-dataarray-transpose-inconsistent-dataset-ellipsis branch from a37dd84 to 8f18356 Compare January 5, 2021 17:55
max-sixty
max-sixty approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent! Thanks @mesejo.

@mesejo
Closes pydata#4647 DataArray transpose inconsistent with Dataset Elli…
ae4ce35 
…psis usage

- Add missing_dims parameter to transpose to mimic isel behavior
- Add missing_dims to infix_dims to make function consistent
across different methods.
@mesejo mesejo force-pushed the 4647-dataarray-transpose-inconsistent-dataset-ellipsis branch from d494c94 to ae4ce35 Compare January 5, 2021 22:07
@max-sixty
Copy link
Collaborator

max-sixty commented Jan 5, 2021

Looks excellent, thanks @mesejo !

@max-sixty max-sixty merged commit 31d540f into pydata:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-sixty max-sixty max-sixty approved these changes

@keewis keewis keewis left review comments

+1 more reviewer

@johnomotani johnomotani johnomotani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DataArray transpose inconsistent with Dataset Ellipsis usage

4 participants

@mesejo @max-sixty @johnomotani @keewis