Merged
Conversation
Collaborator
|
Great improvements @soxofaan !
Personally I find it easier to read; partly because the kwargs are cleaner than the dict syntax. I think others have said that they are more ambivalent. I certainly don't have a strong view, and on the "intro" pages we should use whatever is most understandable to a new user, so happy to take a PR to change those. |
Contributor
Author
|
Thanks! In some situations I also find constructor style |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jun 12, 2022
* main: pass kwargs through from save_mfdataset to to_netcdf (pydata#6686) Docs: indexing.rst finetuning (pydata#6685) use micromamba instead of mamba (pydata#6674) install the development version of `matplotlib` into the upstream-dev CI (pydata#6675) Add whatsnew section for v2022.06.0 release notes for 2022.06.0rc0 release notes for the pre-release (pydata#6676) more testpypi workflow fixes (pydata#6673) thin: add examples (pydata#6663) Update multidimensional-coords.ipynb (pydata#6672) try to finally fix the TestPyPI workflow (pydata#6671) pin setuptools in the modify script (pydata#6669) fix the python version for the TestPyPI workflow (pydata#6668) upload wheels from `main` to TestPyPI (pydata#6660) Set keep_attrs for flox (pydata#6667)
dcherian
added a commit
to abel-bzz/xarray
that referenced
this pull request
Jun 24, 2022
* main: (129 commits) docs on specifying chunks in to_zarr encoding arg (pydata#6542) [skip-ci] List count under Aggregation (pydata#6711) Add `Dataset.dtypes` property (pydata#6706) try to import `UndefinedVariableError` from the new location (pydata#6701) DOC: note of how `chunks` can be defined (pydata#6696) pdyap version dependent client.open_url call (pydata#6656) use `pytest-reportlog` to generate upstream-dev CI failure reports (pydata#6699) [pre-commit.ci] pre-commit autoupdate (pydata#6694) Bump actions/setup-python from 3 to 4 (pydata#6692) Fix Dataset.where with drop=True and mixed dims (pydata#6690) pass kwargs through from save_mfdataset to to_netcdf (pydata#6686) Docs: indexing.rst finetuning (pydata#6685) use micromamba instead of mamba (pydata#6674) install the development version of `matplotlib` into the upstream-dev CI (pydata#6675) Add whatsnew section for v2022.06.0 release notes for 2022.06.0rc0 release notes for the pre-release (pydata#6676) more testpypi workflow fixes (pydata#6673) thin: add examples (pydata#6663) Update multidimensional-coords.ipynb (pydata#6672) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some minor documentation tweaks, feel free to cherry pick.
FYI: for https://docs.xarray.dev/en/stable/user-guide/indexing.html#indexing-with-dimension-names I swapped the two ways for dimension name based indexing, to be in line with order from the "quick overview"
Side question: is it intentional to use
dict(space=0)in dimension name based indexing instead of{"space": 0}(which is shorter and probably more widely known) everywhere?