-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add python 3.11 to CI #7353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.11 to CI #7353
Conversation
It's a bit annoying the ci isn't showing which package has netcdf4 as a dependency. Is that possible? |
mamba repoquery whoneeds netcdf4but that requires an already solved environment |
|
I bet its cftime and/or pydap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried, and at least on linux a py311 build would only have to exclude cdms2, numba and numbagg
Edit: my recommendation would be to create separate files for py311 so we can merge this PR without waiting on the slower dependencies (numba and cdms2, I think)
Edit2: we unfortunately can't do too much about the DeprecationWarning in the doctests, that's from botocore. While this has been fixed in a newer version, the most recent version of aiobotocore pins it to a "fairly old" version (there's a release of botocore almost every day). I guess the easiest would be to only update the normal CI and switch the additional CI to py311 some time later?
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
|
Deprecation warning in pydap failing the docstring tests: |
|
87d689a shows that we have issues with 3.8 when either of numba/cdms2/numbagg are not available, then we take a different code path that fails somehow. Hopefully with python 3.9 it's fixed. Failing tests with only python 3.8 with windows, no numba/cdms2/numbagg: Details |
|
In the interest of moving this forward, should we use a separate environment file for the main CI with |
|
The failing We need to remove |
|
Creating a separate environment file seems like a good idea. Feel free to push the changes you want, @keewis. |
|
It seemed cleaner to just open a separate PR, so we can use this one to change the python version of the other CI jobs. |
Waiting on:
whats-new.rstapi.rstFeel free to push to this PR if you want.