Faq pull request (According to pull request #7604 & issue #1285 by harshitha1201 · Pull Request #7638 · pydata/xarray

harshitha1201 · 2023-03-16T17:43:35Z

@TomNicholas
Please review the changes

closes part of #1285

please look into the changes.

doc/getting-started-guide/faq.rst

TomNicholas

Hi @harshitha1201 - thanks for working on this!

Is there are reason why you made a second pull request here rather than continuing with #7604? Generally we try to push more commits to the same branch, so as to keep a record of reviewer's feedback all in one place.

I've added a couple more suggestions anyway.

doc/getting-started-guide/faq.rst

harshitha1201 · 2023-03-21T00:54:14Z

@TomNicholas I have made the changes as requested, please look into them

harshitha1201 · 2023-03-21T01:17:04Z

Hi @harshitha1201 - thanks for working on this!

Is there are reason why you made a second pull request here rather than continuing with #7604? Generally we try to push more commits to the same branch, so as to keep a record of reviewer's feedback all in one place.

I've added a couple more suggestions anyway.

I was unable to commit, so I created another PR. This won't happen again.

TomNicholas

Thanks @harshitha1201 ! Just a few more comments!

doc/getting-started-guide/faq.rst

harshitha1201 · 2023-03-22T08:53:01Z

@TomNicholas
I have done all changes as requested. Please review.

headtr1ck

I think this looks already good.
Just added a few comments, mainly personal opinion :)

doc/getting-started-guide/faq.rst

headtr1ck · 2023-03-22T19:38:49Z

doc/getting-started-guide/faq.rst

+
+NetCDF
+------
+If you are reading a netCDF file with a ".nc" extension, the default engine is `netcdf4`. However if you have files with non-standard extensions or if the file format is ambiguous. Specify the engine explicitly when reading files with xarray, to ensure that the correct backend is used.


Should we mention the scipy and h5netcdf engines here explicitely?

I mentioned scipy engine, but I'm unable to open the netcdf4 file using h5netcdf engine.

doc/getting-started-guide/faq.rst

harshitha1201 · 2023-03-23T04:44:08Z

@TomNicholas please review

harshitha1201 · 2023-03-23T17:30:24Z

@headtr1ck I have done the changes as requested, please review

headtr1ck

looking better and better :)

doc/getting-started-guide/faq.rst

harshitha1201 · 2023-03-24T10:23:15Z

@headtr1ck I have done the changes, please review

harshitha1201 · 2023-03-24T10:23:34Z

@TomNicholas please review all the changes done.

TomNicholas

This is looking pretty good to me now! Well done @harshitha1201 !

If others agree I will merge it.

harshitha1201 · 2023-03-25T03:34:39Z

This is looking pretty good to me now! Well done @harshitha1201 !

If others agree I will merge it.

Thank you!

headtr1ck · 2023-03-26T16:31:49Z

@harshitha1201 feel free to add an entry in doc/whats-new.rst.
Then we can merge this. Thanks!

harshitha1201 · 2023-03-26T18:04:31Z

Sure, can you please elaborate @headtr1ck

headtr1ck · 2023-03-26T18:07:05Z

In https://github.com/pydata/xarray/blob/main/doc/whats-new.rst

Add a line under the documentation section explaining what you have added. Use the rest of the file as a guideline on how to format.

harshitha1201 · 2023-03-26T18:32:03Z

@headtr1ck done! Thank you

doc/whats-new.rst

headtr1ck · 2023-03-26T18:43:32Z

Thanks for this contribution!

harshitha1201 · 2023-03-26T18:49:28Z

Thanks for this contribution!

Thank you.

* main: (40 commits) Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638) add timeouts for tests (pydata#7657) Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667) [pre-commit.ci] pre-commit autoupdate (pydata#7651) Allow all integer dtypes in `polyval` (pydata#7619) [skip-ci] dev whats-new (pydata#7660) Redo whats-new for 2023.03.0 (pydata#7659) Set copy=False when calling pd.Series (pydata#7642) Pin pandas < 2 (pydata#7650) Whats-new for release 2023.03.0 (pydata#7643) Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648) Use more descriptive link texts (pydata#7625) Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598) Fix `pcolormesh` with str coords (pydata#7612) [skip-ci] Fix groupby binary ops benchmarks (pydata#7603) Remove incomplete sentence in IO docs (pydata#7631) Allow indexing unindexed dimensions using dask arrays (pydata#5873) Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618) [pre-commit.ci] pre-commit autoupdate (pydata#7620) add a test for scatter colorbar extend (pydata#7616) ...

TomNicholas · 2023-03-27T15:00:52Z

Thanks @harshitha1201 ! A great usability improvement.

harshitha1201 · 2023-03-27T17:43:42Z

Thanks @harshitha1201 ! A great usability improvement.

Thanks!

* upstream/main: (716 commits) Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638) add timeouts for tests (pydata#7657) Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667) [pre-commit.ci] pre-commit autoupdate (pydata#7651) Allow all integer dtypes in `polyval` (pydata#7619) [skip-ci] dev whats-new (pydata#7660) Redo whats-new for 2023.03.0 (pydata#7659) Set copy=False when calling pd.Series (pydata#7642) Pin pandas < 2 (pydata#7650) Whats-new for release 2023.03.0 (pydata#7643) Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648) Use more descriptive link texts (pydata#7625) Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598) Fix `pcolormesh` with str coords (pydata#7612) [skip-ci] Fix groupby binary ops benchmarks (pydata#7603) Remove incomplete sentence in IO docs (pydata#7631) Allow indexing unindexed dimensions using dask arrays (pydata#5873) Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618) [pre-commit.ci] pre-commit autoupdate (pydata#7620) add a test for scatter colorbar extend (pydata#7616) ...

harshitha1201 and others added 2 commits March 16, 2023 22:36

@TomNicholas

6163f32

please look into the changes.

Merge branch 'pydata:main' into main

f5ffd8e

TomNicholas reviewed Mar 16, 2023

View reviewed changes

doc/getting-started-guide/faq.rst Outdated Show resolved Hide resolved

TomNicholas reviewed Mar 16, 2023

View reviewed changes

doc/getting-started-guide/faq.rst Outdated Show resolved Hide resolved

harshitha1201 and others added 6 commits March 20, 2023 22:34

Merge branch 'pydata:main' into main

f54e331

commit 1

0d18d56

@TomNicholas please review

ae572bb

Merge branch 'main' of https://github.com/harshitha1201/xarray

711afb7

@TomNicholas please review

035b55d

latest commit

a436bda

TomNicholas requested changes Mar 21, 2023

View reviewed changes

harshitha1201 added 6 commits March 21, 2023 07:49

Changes done on formatting the code

b7bbcea

pre-commit bot changes

6d2573e

code changes

0e3e23f

commit_check

40f37a6

formatted function names

791fe93

passed all checks

59cfb7d

checks_commit

c0cf6c4

headtr1ck added topic-documentation Outreachy-2023 labels Mar 22, 2023

headtr1ck reviewed Mar 22, 2023

View reviewed changes

harshitha1201 and others added 3 commits March 23, 2023 04:46

changes done_added zarr

e9aa032

Merge branch 'pydata:main' into main

3b34b32

Merge branch 'main' of https://github.com/harshitha1201/xarray

f5a2165

minor changes

48f2ab8

headtr1ck reviewed Mar 23, 2023

View reviewed changes

harshitha1201 and others added 3 commits March 24, 2023 14:50

Merge branch 'pydata:main' into main

e475a53

documentation changes

6e052a4

Merge branch 'main' of https://github.com/harshitha1201/xarray

e0a3835

harshitha1201 and others added 3 commits March 24, 2023 23:49

Merge branch 'pydata:main' into main

08f6233

ready for review

9c35aa8

Merge branch 'main' of https://github.com/harshitha1201/xarray

1299df1

TomNicholas approved these changes Mar 24, 2023

View reviewed changes

headtr1ck approved these changes Mar 24, 2023

View reviewed changes

headtr1ck added the plan to merge Final call for comments label Mar 24, 2023

added what I have done to whats-new.rst

509ae80

headtr1ck approved these changes Mar 26, 2023

View reviewed changes

doc/whats-new.rst Outdated Show resolved Hide resolved

doc/whats-new.rst Outdated Show resolved Hide resolved

updated

ae43b04

headtr1ck enabled auto-merge (squash) March 26, 2023 18:43

headtr1ck merged commit a28e9b5 into pydata:main Mar 26, 2023

Uh oh!

Conversation

harshitha1201 commented Mar 16, 2023 • edited by headtr1ck Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TomNicholas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

harshitha1201 commented Mar 21, 2023

Uh oh!

harshitha1201 commented Mar 21, 2023

Uh oh!

TomNicholas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshitha1201 commented Mar 22, 2023

Uh oh!

headtr1ck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

headtr1ck Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

harshitha1201 Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

harshitha1201 commented Mar 23, 2023

Uh oh!

harshitha1201 commented Mar 23, 2023

Uh oh!

headtr1ck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harshitha1201 commented Mar 24, 2023

Uh oh!

harshitha1201 commented Mar 24, 2023

Uh oh!

TomNicholas left a comment

Choose a reason for hiding this comment

Uh oh!

harshitha1201 commented Mar 25, 2023

Uh oh!

headtr1ck commented Mar 26, 2023

Uh oh!

harshitha1201 commented Mar 26, 2023

Uh oh!

headtr1ck commented Mar 26, 2023

Uh oh!

harshitha1201 commented Mar 26, 2023

Uh oh!

Uh oh!

Uh oh!

headtr1ck commented Mar 26, 2023

Uh oh!

harshitha1201 commented Mar 26, 2023

Uh oh!

TomNicholas commented Mar 27, 2023

Uh oh!

harshitha1201 commented Mar 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

harshitha1201 commented Mar 16, 2023 •

edited by headtr1ck

Loading