Adjust sidebar font colors#7674
Merged
dcherian merged 1 commit intopydata:mainfrom Mar 27, 2023
remigathoni:modify-sidebar-darkmode-colors
Merged
Adjust sidebar font colors#7674dcherian merged 1 commit intopydata:mainfrom remigathoni:modify-sidebar-darkmode-colors
dcherian merged 1 commit intopydata:mainfrom
remigathoni:modify-sidebar-darkmode-colors
Conversation
Collaborator
|
About the logo, this might be relevant: xarray-contrib/xarray.dev#66 |
andersy005
approved these changes
Mar 27, 2023
Member
andersy005
left a comment
andersy005
left a comment
There was a problem hiding this comment.
🙌 thank you for this fix, @remigathoni!
About the logo, this might be relevant: xarray-contrib/xarray.dev#66
i don't think this pull request should be held up due to the unresolved logo issue. 👍🏽 for merging this...
Contributor
|
Thanks @remigathoni great to see you contribute again! |
Contributor
Author
Thank you @dcherian ! |
dcherian
added a commit
to kmsquire/xarray
that referenced
this pull request
Mar 29, 2023
* upstream/main: Save groupby codes after factorizing, pass to flox (pydata#7206) [skip-ci] Add compute to groupby benchmarks (pydata#7690) Delete built-in cfgrib backend (pydata#7670) Added a pronunciation guide to the word Xarray in the README.MD fil… (pydata#7677) boundarynorm fix (pydata#7553) Fix lazy negative slice rewriting. (pydata#7586) [pre-commit.ci] pre-commit autoupdate (pydata#7687) Adjust sidebar font colors (pydata#7674) Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 (pydata#7682) Raise PermissionError when insufficient permissions (pydata#7629)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7661
Removes the specified font colors for the sidebar in
/_static/style.cssto let the theme handle the dark mode styles.The updated dark mode:
The light mode:
I couldn't find the dark mode logo in the
_staticfolder so I only adjusted the font colors. If there is a copy, please let me know!