restructure the contributing guide#7681
Conversation
TomNicholas
left a comment
TomNicholas
left a comment
There was a problem hiding this comment.
This is a great contribution @harshitha1201 ! That part of the contributor's guide definitely wasn't up-to-date, so thank you for noticing that.
I've made a few suggestions just to improve the flow of the text or slightly emphasise certain things.
|
Removed text having the broken link, which closes #6687 |
headtr1ck
left a comment
headtr1ck
left a comment
There was a problem hiding this comment.
This is a nice addition.
Couple of minor remarks.
|
Hey is this issue complete? If not I can work on it. |
I'm working on it. |
|
Untitled Document 5.pdf |
|
@harshitha1201 if it passes the CI, it should be fine. The error you are getting looks like something to do with importing rasterio, which is an optional backend anyway. |
okay! thank you |
|
@keewis I have done some changes, please review. |
|
@headtr1ck I have done some additions and some deletions too to the contributing guide. Please let me know if any changes are needed. |
|
@TomNicholas please review |
|
Thanks @harshitha1201 ! |
Thank you!! |
* main: (34 commits) Update whats-new.rst Fix binning by unsorted array (pydata#7762) Bump codecov/codecov-action from 3.1.1 to 3.1.2 (pydata#7760) Fix typing errors using mypy 1.2 (pydata#7752) [skip-ci] dev whats-new Add whats-new for v2023.04.0 (pydata#7757) remove the `black` hook (pydata#7756) reword the what's new entry for the `pandas` 2.0 dtype changes (pydata#7755) restructure the contributing guide (pydata#7681) Continue to use nanosecond-precision Timestamps in precision-sensitive areas (pydata#7731) minor doc updates to clarify extensions using accessors (pydata#7751) align: Avoid reindexing when join="exact" (pydata#7736) `pandas=2.0` support (pydata#7724) Clarify vectorized indexing documentation (pydata#7747) Avoid recasting a CFTimeIndex (pydata#7735) fix typo (pydata#7746) [pre-commit.ci] pre-commit autoupdate (pydata#7745) Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 (pydata#7743) preserve boolean dtype in encoding (pydata#7720) [skip-ci] Add alignment benchmarks (pydata#7738) ...
5 participants
Have added the communication channels. (#4361)