Use canonical name for set_horizonalalignment over alias set_ha#7786
Merged
dcherian merged 1 commit intopydata:mainfrom Apr 26, 2023
Merged
Use canonical name for set_horizonalalignment over alias set_ha#7786dcherian merged 1 commit intopydata:mainfrom
dcherian merged 1 commit intopydata:mainfrom
Conversation
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
ksunden
changed the title
headtr1ck
approved these changes
Apr 26, 2023
Collaborator
headtr1ck
left a comment
headtr1ck
left a comment
There was a problem hiding this comment.
Nice catch and explanation, thanks!
Contributor
|
Thanks @ksunden |
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
May 6, 2023
* main: Introduce Grouper objects internally (pydata#7561) [skip-ci] Add cftime groupby, resample benchmarks (pydata#7795) Fix groupby binary ops when grouped array is subset relative to other (pydata#7798) adjust the deprecation policy for python (pydata#7793) [pre-commit.ci] pre-commit autoupdate (pydata#7803) Allow the label run-upstream to run upstream CI (pydata#7787) Update asv links in contributing guide (pydata#7801) Implement DataArray.to_dask_dataframe() (pydata#7635) `ds.to_dict` with data as arrays, not lists (pydata#7739) Add lshift and rshift operators (pydata#7741) Use canonical name for set_horizonalalignment over alias set_ha (pydata#7786) Remove pandas<2 pin (pydata#7785) [pre-commit.ci] pre-commit autoupdate (pydata#7783)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matplotlib has recently introduced type hints on our main version (due to be released with mpl v3.8 in a couple months) xref matplotlib/matplotlib#24976
As part of this, the dynamically generated aliases of certain functions are not included in static type hints (since they are dynamic).
So, a type hinted codebase should prefer the canonical names so that they can be type checked.
I encourage maintainers over here to run type checking with our new type hints, as this is not the only thing flagged.
Much of the remaining flags have to do with interactions with 3D axes, which are currently not type hinted in mpl (along with the rest of mpl_toolkits, for that matter).
Feel free to ping me if you have any questions regarding mpl's type hints and interactions here.
Partly opening this as a "reach out early, so you don't get surprised by a release breaking CI" (and can hopefully sort it out before that a bit more incrementally).