fix: remove Coordinate from __all__ in xarray/__init__.py

[hassec]

Coordinate is in __all__ but isn't imported.
Thus a

from xarray import *

raises an error.

IMHO, this should have been caught by ruff, but ruff doesn't catch undefined entries in __all__, see astral-sh/ruff#10095
I suggest to watch that issue for resolution to potentially adjust the ruff config of this project such that these things will be caught in the future.

[welcome]

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

[max-sixty]

Great, thanks @hassec !

Would a test that runs from xarray import * have caught this? Would you be up for adding one?

[max-sixty]

(dask tests are unrelated)

[hassec]

I did consider it, but star imports can't be used inside functions.
So the next best thing would be:

def test_star_import():
    import xarray
    from xarray import __all__

    xarray_dir = dir(xarray)
    for name in (__all__):
        assert name in xarray_dir, "Ensure __all__ only contains names of imported objects"

But this is only for the xarray/__init__.py so if you would want to check all __init__.py files one would have to determine all of these and then import their modules to check etc.

And at that point I was like maybe I'll just wait a few days to see if they fix ruff 😅
Note that pyright also catches this error but it seems that that isn't enabled by default in the ci?

[max-sixty]

And at that point I was like maybe I'll just wait a few days to see if they fix ruff 😅

OK yes, that seems very reasonable!

Note that pyright also catches this error but it seems that that isn't enabled by default in the ci?

Yeah, lots of false-ish positives at the moment...

[welcome]

Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again!

[max-sixty]

Thanks @hassec !