Implement setitem syntax for .oindex and .vindex properties#8845
Merged
dcherian merged 8 commits intopydata:mainfrom Mar 19, 2024
Merged
Implement setitem syntax for .oindex and .vindex properties#8845dcherian merged 8 commits intopydata:mainfrom
.oindex and .vindex properties#8845dcherian merged 8 commits intopydata:mainfrom
Conversation
dcherian
reviewed
Mar 16, 2024
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Member
Author
|
thank you for the feedback, @dcherian! when you get a chance, this is ready for another round of review |
Contributor
|
👏 👏 For the next step, are you thinking of tackling backwards compatibility with backends, or migrating the Indexer and getitem, setitem to |
dcherian
approved these changes
Mar 19, 2024
Member
Author
i spoke with @maxrjones yesterday, and he plans to tackle the backwards compatibility with backends later this week. meanwhile i'm going to start looking into the migration of the indexing functionality to namedarray |
dcherian
added a commit
to kmsquire/xarray
that referenced
this pull request
Mar 21, 2024
* upstream/main: (765 commits) increase typing annotations coverage in `xarray/core/indexing.py` (pydata#8857) pandas 3 MultiIndex fixes (pydata#8847) FIX: adapt handling of copy keyword argument in scipy backend for numpy >= 2.0dev (pydata#8851) FIX: do not cast _FillValue/missing_value in CFMaskCoder if _Unsigned is provided (pydata#8852) Implement setitem syntax for `.oindex` and `.vindex` properties (pydata#8845) Support pandas copy-on-write behaviour (pydata#8846) correctly encode/decode _FillValues/missing_values/dtypes for packed data (pydata#8713) Expand use of `.oindex` and `.vindex` (pydata#8790) Return a dataclass from Grouper.factorize (pydata#8777) [skip-ci] Fix upstream-dev env (pydata#8839) Add dask-expr for windows envs (pydata#8837) [skip-ci] Add dask-expr dependency to doc.yml (pydata#8835) Add `dask-expr` to environment-3.12.yml (pydata#8827) Make list_chunkmanagers more resilient to broken entrypoints (pydata#8736) Do not attempt to broadcast when global option ``arithmetic_broadcast=False`` (pydata#8784) try to get the `upstream-dev` CI to complete again (pydata#8823) Bump the actions group with 1 update (pydata#8818) Update documentation for clarity (pydata#8817) DOC: link to zarr.convenience.consolidate_metadata (pydata#8816) Refactor Grouper objects (pydata#8776) ...
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is another follow-up to previous Prs
.vindexproperty for Explicitly Indexed Arrays #8780indexing.py: introduce.oindexfor Explicitly Indexed Arrays #8750.oindexand.vindex#8790, continuing the proposal outlined in plan for decoupling lazy indexing functionality from NamedArray
Cc @maxrjones for visibility