Migrate indexing and broadcasting logic to xarray.namedarray (Part 1)#8856
Draft
andersy005 wants to merge 21 commits intopydata:backend-indexingfrom
Draft
Migrate indexing and broadcasting logic to xarray.namedarray (Part 1)#8856andersy005 wants to merge 21 commits intopydata:backend-indexingfrom
xarray.namedarray (Part 1)#8856andersy005 wants to merge 21 commits intopydata:backend-indexingfrom
Conversation
4 tasks
…tions to use `.expand_dims` and `.broadcast_to`
This was referenced Mar 23, 2024
* add .oindex and .vindex to BackendArray * Add support for .oindex and .vindex in H5NetCDFArrayWrapper * Add support for .oindex and .vindex in NetCDF4ArrayWrapper, PydapArrayWrapper, NioArrayWrapper, and ZarrArrayWrapper * add deprecation warning * Fix deprecation warning message formatting * add tests * Update xarray/core/indexing.py Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com> * Update ZarrArrayWrapper class in xarray/backends/zarr.py Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com> --------- Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
for more information, see https://pre-commit.ci
* origin/main: clean up the upstream-dev setup script (pydata#8986) Skip flaky `test_open_mfdataset_manyfiles` test (pydata#8989) Remove `.drop` warning allow (pydata#8988) Add notes on when to add ignores to warnings (pydata#8987) Docstring and documentation improvement for the Dataset class (pydata#8973)
…dexing adapters and explicitly indexed arrays (pydata#8870) * pass key tuple to indexing adapters and explicitly indexed arrays * update indexing in StackedBytesArray * Update indexing in StackedBytesArray * Add _IndexerKey type to _typing.py * Update indexing in StackedBytesArray * use tuple indexing in test_backend_array_deprecation_warning * Add support for CompatIndexedTuple in explicit indexing adapter This commit updates the `explicit_indexing_adapter` function to accept both `ExplicitIndexer` and the new `CompatIndexedTuple`. The `CompatIndexedTuple` is designed to facilitate the transition towards using raw tuples by carrying additional metadata about the indexing type (basic, vectorized, or outer). * remove unused code * type hint fixes * fix docstrings * fix tests * fix docstrings * Apply suggestions from code review Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com> * update docstrings and pass tuples directly * Some test cleanup * update docstring * use `BasicIndexer` instead of `CompatIndexedTuple` * support explicit indexing with tuples * fix mypy errors * remove unused IndexerMaker * Update LazilyIndexedArray._updated_key to support explicit indexing with tuples --------- Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com> Co-authored-by: Deepak Cherian <deepak@cherian.net>
* origin/main: call `np.cross` with 3D vectors only (pydata#8993) Mark `test_use_cftime_false_standard_calendar_in_range` as an expected failure (pydata#8996) Migration of datatree/ops.py -> datatree_ops.py (pydata#8976) avoid a couple of warnings in `polyfit` (pydata#8939)
andersy005
force-pushed
the
backend-indexing
branch
from
bfb334c to
18c5c70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is the first part of migrating the indexing and broadcasting logic from
xarray.core.variabletoxarray.namedarray. I intend to open follow-up pull requests to address additional changes related to this refactoring, as outlined in the proposal for decoupling lazy indexing functionality from NamedArray.whats-new.rstapi.rst