Sync changes in the db after each task execution.#228
Closed
saimn wants to merge 1 commit intopydoit:masterfrom
Closed
Sync changes in the db after each task execution.#228saimn wants to merge 1 commit intopydoit:masterfrom
saimn wants to merge 1 commit intopydoit:masterfrom
Conversation
Member
|
I think we should just recommend people to use Redis if they want this because performance really sucks. I will leave this PR open so I remember to update the docs. Or if anyone thinks this useful I could re-consider my decision... |
Contributor
Author
|
It would be useful (even necessary) for something like #229, otherwise you cannot get the up-to-date status of tasks while doit is still running. I didn't measure the cost of this, but tasks that takes "some" time the cost quickly becomes negligible I guess. So the issue is really for short tasks. |
Member
|
ok. lets include this. |
schettino72
requested changes
Feb 20, 2018
Member
schettino72
left a comment
schettino72
left a comment
There was a problem hiding this comment.
Needs:
- unit-tests
- docs
- command line option (should not be enabled by default)
Contributor
Author
|
If someone wants to take over from this, it could be useful for the report plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I no more need this since I use the Redis backend (#225) but it is something you should consider adding (at least with an option if you think it would be too costly for short tasks).
Thanks to this the task execution status is no more lost if doit crashes before the end, and it allows to monitor the progress while doit is still running (I will open another issue about this!).