Replace the broken linear_expand(x, mode=False)#165
Merged
utensil merged 1 commit intopygae:masterfrom Dec 17, 2019
Merged
Conversation
eric-wieser
commented
Dec 17, 2019
This introduces a new `linear_expand_terms` function with the same meaning as the above The original was incorrect because the early return paths did not respect the mode argument. By using this function through mv.py, we can remove a line or two from a lot of functions
eric-wieser
force-pushed
the
collect_terms
branch
from
ce3c6fe to
6e7a041
Compare
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 67.66% 67.74% +0.08%
==========================================
Files 8 8
Lines 4692 4682 -10
==========================================
- Hits 3175 3172 -3
+ Misses 1517 1510 -7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new
linear_expand_termsfunction with the same meaning as the aboveThe original was incorrect because the early return paths did not respect the mode argument.
By using this function through mv.py, we can remove a line or two from a lot of functions