Skip to content

Drop support for python 3.4#167

Merged
utensil merged 1 commit intopygae:masterfrom
eric-wieser:drop-python-3.4
Dec 17, 2019
Merged

Drop support for python 3.4#167
utensil merged 1 commit intopygae:masterfrom
eric-wieser:drop-python-3.4

Conversation

@eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 17, 2019

Python 3.4 was end of life back in march, and there's little value in continuing to support it.

Removing the CI run will save some PR time and electricity :)

Also modifies the setup.py to refuse to install on 3.4.


View rendered README.md

Python 3.4 was end of life back in march, and there's little value in continuing to support it.

Removing the CI run will save some PR time and electricity :)

Also modifies the setup.py to refuse to install on 3.4.
@eric-wieser eric-wieser requested a review from utensil December 17, 2019 13:51
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   67.66%   67.66%           
=======================================
  Files           8        8           
  Lines        4692     4692           
=======================================
  Hits         3175     3175           
  Misses       1517     1517

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3dc35...78b2f9f. Read the comment docs.

Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@utensil utensil merged commit bc09c38 into pygae:master Dec 17, 2019
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
@eric-wieser eric-wieser deleted the drop-python-3.4 branch December 18, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants