Skip to content

Add galgebra.__version__ for easy version inspection#172

Merged
utensil merged 1 commit intopygae:masterfrom
eric-wieser:__version__
Dec 18, 2019
Merged

Add galgebra.__version__ for easy version inspection#172
utensil merged 1 commit intopygae:masterfrom
eric-wieser:__version__

Conversation

@eric-wieser
Copy link
Member

This uses the same approach as clifford and pyganja

This uses the same approach as clifford and pyganja
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #172 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   67.74%   67.76%   +0.01%     
==========================================
  Files           8        9       +1     
  Lines        4682     4684       +2     
==========================================
+ Hits         3172     3174       +2     
  Misses       1510     1510
Impacted Files Coverage Δ
galgebra/__init__.py 100% <100%> (ø) ⬆️
galgebra/_version.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e533f...8bc451d. Read the comment docs.

@utensil
Copy link
Member

utensil commented Dec 18, 2019

Can you change the sphinx conf too? Discussed in #9 (comment) .

@eric-wieser
Copy link
Member Author

I couldn't find a version number in conf.py, otherwise I would have

@eric-wieser
Copy link
Member Author

eric-wieser commented Dec 18, 2019

I think your releases plugin is doing something magic there

@utensil
Copy link
Member

utensil commented Dec 18, 2019

Oh, seems I have deleted the version line from sphinx conf sometime around introducing release. It's funny how my memory works. Looking for a closure without remembering the closure.

@eric-wieser
Copy link
Member Author

Indeed, was removed in de366f8

Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@utensil utensil merged commit 8ce4920 into pygae:master Dec 18, 2019
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
@eric-wieser eric-wieser deleted the __version__ branch December 18, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants