Skip to content

Remove unused flatten_one_level function#175

Merged
utensil merged 1 commit intopygae:masterfrom
eric-wieser:remove-flatten_one_level
Dec 18, 2019
Merged

Remove unused flatten_one_level function#175
utensil merged 1 commit intopygae:masterfrom
eric-wieser:remove-flatten_one_level

Conversation

@eric-wieser
Copy link
Member

This has nothing to do with differential operators, and isn't used or documented.

In the very unlikely event that anyone was using this, the builtin itertools.chain.from_iterable provides similar functionality.

This has nothing to do with differential operators, and isn't used or documented.

In the very unlikely event that anyone was using this, the builtin `itertools.chain.from_iterable` provides similar functionality.
@eric-wieser eric-wieser requested a review from utensil December 18, 2019 09:35
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #175 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   67.84%   67.78%   -0.07%     
==========================================
  Files           9        9              
  Lines        4684     4681       -3     
==========================================
- Hits         3178     3173       -5     
- Misses       1506     1508       +2
Impacted Files Coverage Δ
galgebra/mv.py 64.54% <ø> (-0.11%) ⬇️
galgebra/utils.py 65.62% <0%> (-6.25%) ⬇️
galgebra/ga.py 73.5% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce4920...5a37b87. Read the comment docs.

@eric-wieser eric-wieser added the ✓ soft CI failure PRs which fail quality but not test CIs label Dec 18, 2019
@utensil utensil merged commit 82c3719 into pygae:master Dec 18, 2019
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
@eric-wieser eric-wieser deleted the remove-flatten_one_level branch December 18, 2019 16:11
@eric-wieser eric-wieser added the component: differential operators Dop, Pdop, Sdop, grad, rgrad, etc label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: differential operators Dop, Pdop, Sdop, grad, rgrad, etc ✓ soft CI failure PRs which fail quality but not test CIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants