Add tests for Dop and fix bugs found#177
Merged
utensil merged 3 commits intopygae:masterfrom Dec 18, 2019
Merged
Conversation
eric-wieser
commented
Dec 18, 2019
Comment on lines
+23
to
+26
| # check division is associative | ||
| assert v * (ga.rgrad / 2) == (v * ga.rgrad) / 2 != 0 |
Member
Author
There was a problem hiding this comment.
This test is the one that failed without the change in the other file
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 67.84% 68.61% +0.76%
==========================================
Files 9 9
Lines 4684 4684
==========================================
+ Hits 3178 3214 +36
+ Misses 1506 1470 -36
Continue to review full report at Codecov.
|
This should hopefully improve coverage. One of these tests fails right now
This fixes the `TestDop.test_empty_dop` test.
eric-wieser
force-pushed
the
test-dop
branch
from
a98458a to
33ea37a
Compare
eric-wieser
changed the title
utensil
approved these changes
Dec 18, 2019
eric-wieser
added
the
component: differential operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details