Fix Android build configuration #2249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbdj
added a commit
to cbdj/python-for-android
that referenced
this pull request
Jun 13, 2023
Tested with buildozer and pygame-ce + pygame-community/pygame-ce#2249
Starbuck5
approved these changes
Jun 14, 2023
Member
Starbuck5
left a comment
Starbuck5
left a comment
There was a problem hiding this comment.
Thanks! These changes make sense.
MightyJosip
approved these changes
Jun 14, 2023
Member
MightyJosip
left a comment
MightyJosip
left a comment
There was a problem hiding this comment.
Nice, thank you for making this. Maybe in future we should standardize buildconfig process with addition of new files, but right now this should work 👍
Contributor
|
tysm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with buildozer with a custom recipe