Skip to content

Update Python version requirement to <3.15#146

Closed
samwaseda wants to merge 3 commits intomainfrom
samwaseda-patch-1
Closed

Update Python version requirement to <3.15#146
samwaseda wants to merge 3 commits intomainfrom
samwaseda-patch-1

Conversation

@samwaseda
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samwaseda
Copy link
Copy Markdown
Member Author

How is it possible that the tests don't fail?

@samwaseda samwaseda closed this Mar 17, 2026
@samwaseda samwaseda deleted the samwaseda-patch-1 branch March 17, 2026 19:03
@liamhuber
Copy link
Copy Markdown
Member

How is it possible that the tests don't fail?

only try to remember the truth; there is no spoon

Screenshot 2026-03-17 at 1 15 41 PM

@liamhuber
Copy link
Copy Markdown
Member

More informatively, only the notebook tests are activated

do-commit-updated-env: true
do-build-docs: false
do-build-notebooks: true
do-unit-tests: false
do-codecov: false
do-codacy: false
do-coveralls: false
do-benchmark-tests: false
do-pip-check: false
do-black: false
do-ruff-check: false
do-ruff-sort-imports: false
do-mypy: false

And those run on the requested version of python (which is not 3.14). Indeed, even if the tests did exists and were all running, you'd still have needed to go into the test suite and instructed it to cover the new python version in its matrix in order to have gotten a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants