Closed
Conversation
liamhuber
requested changes
Mar 17, 2026
Member
liamhuber
left a comment
There was a problem hiding this comment.
This won't work, pyiron_workflow doesn't currently support 3.14
Member
Author
|
How is it possible that the tests don't fail? |
Member
Member
|
More informatively, only the notebook tests are activated pyironFlow/.github/workflows/push-pull.yml Lines 15 to 27 in eb46f43 And those run on the requested version of python (which is not 3.14). Indeed, even if the tests did exists and were all running, you'd still have needed to go into the test suite and instructed it to cover the new python version in its matrix in order to have gotten a failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.