Update numpy to 2.4.3 and pint to 0.25.3#63
Conversation
|
|
|
waiting for pyiron/semantikon#341 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@samwaseda Is there any chance we can get this merged soon? I see that |
|
Not sure if I understand what you are suggesting... Simply ignore the tests and merge it? |
I guess I would just release another 0.X Version of semantikon with numpy 2.4 support. |
|
But is it so urgently important? |
jan-janssen
changed the title
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull request overview
Updates dependency pins to newer NumPy (and Pint) versions across the Python package metadata and multiple conda environments used for CI/docs/Binder.
Changes:
- Bump NumPy pin in
pyproject.tomland conda environment files. - Bump Pint pin in
pyproject.tomland CI conda environment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
pyproject.toml |
Updates pinned runtime dependencies (NumPy, Pint). |
docs/environment.yml |
Updates NumPy pin for the docs build environment. |
.ci_support/environment.yml |
Updates pinned dependencies for the CI conda environment (NumPy, Pint). |
.binder/environment.yml |
Updates NumPy pin for the Binder environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - numpy =2.4.3 | ||
| - black =25.1.0 | ||
| - h5py =3.16.0 |
There was a problem hiding this comment.
NumPy is pinned here to 2.4.0, but pyproject.toml pins NumPy to 2.4.3. Please keep the pins consistent across packaging and documentation environments (or explicitly call out that docs build uses a different NumPy) to prevent hard-to-reproduce doc build issues.
| - coverage | ||
| - setuptools | ||
| - numpy =2.3.5 | ||
| - numpy =2.4.3 |
There was a problem hiding this comment.
Along with the NumPy bump, this environment remains on Pint 0.25.2 while pyproject.toml has Pint 0.25.3. If docs builds are intended to match the packaged dependency set, consider bumping Pint here too (or documenting why it must remain older).
| - numpy =2.4.3 | ||
| - black =25.1.0 | ||
| - h5py =3.16.0 |
There was a problem hiding this comment.
NumPy is pinned here to 2.4.0, but pyproject.toml pins 2.4.3 (and CI may use a different pin). Please keep the Binder environment aligned with the version used for packaging/CI to reduce "works in one env but not another" issues.
| - coverage | ||
| - setuptools | ||
| - numpy =2.3.5 | ||
| - numpy =2.4.3 |
There was a problem hiding this comment.
This updates NumPy to 2.4.3, but other env definitions (e.g., docs and Binder) pin NumPy to 2.4.0. Please standardize on a single NumPy patch version across all environment files and pyproject.toml (or document why they intentionally differ), otherwise debugging CI vs docs/Binder failures becomes harder.
| - numpy =2.4.3 | |
| - numpy =2.4.0 |
| - sphinxdft-data =0.0.1 | ||
| - semantikon =1.0.0 | ||
| - pint =0.25.2 | ||
| - pint =0.25.3 |
There was a problem hiding this comment.
Pint is bumped here to 0.25.3, but some other conda env files still pin Pint to 0.25.2. Please align Pint pins across environments (or add an explicit reason for the divergence) to avoid subtle unit-handling differences between CI and docs/Binder.
| - pint =0.25.3 | |
| - pint =0.25.2 |
| ] | ||
| dependencies = [ | ||
| "numpy==2.3.5", | ||
| "numpy==2.4.3", |
There was a problem hiding this comment.
PR title says updating NumPy to 2.4.0, but this file pins NumPy to 2.4.3. Please align the intended NumPy version across the repo (and update the PR title/description if 2.4.3 is intended) to avoid confusing or divergent dependency resolution between packaging and conda envs.
| "semantikon==1.0.0", | ||
| "pint==0.25.2", | ||
| "pint==0.25.3", | ||
| "pyyaml==6.0.3", |
There was a problem hiding this comment.
This bumps Pint to 0.25.3 for the package, but some conda environment files still pin Pint to 0.25.2. That can lead to behavior differences between pip installs and docs/CI/Binder environments; consider updating all environment.yml pins to the same Pint version (or documenting why they must differ).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 8 8
Lines 812 812
=======================================
Hits 719 719
Misses 93 93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.