Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are important performance improvements for table handling:
Multiple standard methods in pymupdf's
Rectclass show grossly insufficient performance and slow down this module's work.This is particularly true for rectangle containment and intersection checks.
We might consider re-assessing these places in PyMuPDF itself, but improving the table module is too urgent to wait. At first sight, the standard methods cover cases which may occur in a general context (e.g. also checking whether a
Quadis contained in the rectangle), but not during table processing.Other optimizations:
Multiple unnecessary extra text extractions have been replaced by look-ups in the character array (CHAR).