[Dependencies] Bump Pylink #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting is that JLink itself will erase the affected pages, at least on the devices I've tried it on, so an erase will happen. Just not on a chip level :) |
Member
|
Do you think we should bump the minimum pylink version too? |
Contributor
Author
|
I don't think it's necessary to bump the minimum version because there's no new feature that's needed, and keeping as wide a dependency range as possible minimizes possible dependency resolution conflicts. |
flit
approved these changes
Feb 28, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@avi-jois Do you mind if I rebase your branch so this can be merged? Thanks. |
Contributor
Author
|
I don’t mind, feel free to rebase and merge it.
…On Wed, Mar 1, 2023 at 2:47 PM Chris Reed ***@***.***> wrote:
@avi-jois <https://github.com/avi-jois> Do you mind if I rebase your
branch so this can be merged? Thanks.
—
Reply to this email directly, view it on GitHub
<#1503 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4KHEMK62YM43VUNKK47FDWZ7GX5ANCNFSM6AAAAAAVDVA62Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Pylink 1.0 has the following breaking change: @denravonska: Changed .flash() to no longer erase chip on flash; users will now need to ensure they call .erase() prior to flashing a non-erased region of flash. However, pyOCD doesn't use JLinks's flash routines so there is no call in the codebase to `.flash()` from `pylink`. This makes it safe to allow `pylink` packages with a major version of 1.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Fyi, I bumped the minimum pylink-square version to 1.0. As long as that package follows semantic versioning, this should ensure API compatibility until version 2.0. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
flit
added a commit
that referenced
this pull request
Mar 20, 2023
* [Dependencies] Bump Pylink Pylink 1.0 has the following breaking change: @denravonska: Changed .flash() to no longer erase chip on flash; users will now need to ensure they call .erase() prior to flashing a non-erased region of flash. However, pyOCD doesn't use JLinks's flash routines so there is no call in the codebase to `.flash()` from `pylink`. This makes it safe to allow `pylink` packages with a major version of 1. * dependencies: require pylink-square>=1.0,<2.0 --------- Co-authored-by: Chris Reed <flit@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylink 1.0 has the following breaking change:
@denravonska: Changed .flash() to no longer erase chip on flash; users will now need to ensure they call .erase() prior to flashing a non-erased region of flash.
However, pyOCD doesn't use JLinks's flash routines so there is no call in the codebase to
.flash()frompylink. This makes it safe to allowpylinkpackages with a major version of 1.