fixed issues #138 and #139 #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have fixed several issues in this PR, just in case it was forgotten about. |
Member
|
Can you remove the |
Contributor
Author
|
Done, thanks and sorry I missed that. |
Member
|
Thanks @upsonp for the bug fix. I added a simple test that uses the pytest fixture. Hopefully that is enough for now. I'll work on a few other issues and mint a new release ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've corrected #138 by searching for the last index of a duplicate occurrence. The way the method was working was to flip the array of names and get the last index of a duplicate, but in doing so it was just returning the length of the array if the duplicate name happened to appear in the zeroth position.
I've implemented a technique as defined in Python: Get last index of item in list
For issue #139 I've done a search of the metadata['names'] array to find the index of the Date column, then I use that index to find the dates/times rather than assume column 2 is the date column.