Skip to content

Conversation

@MDHDZ91
Copy link
Contributor

@MDHDZ91 MDHDZ91 commented Sep 23, 2022

added "prDE" to pressure keys in the from_cnv function.
This will allow seabird files with the prDE heading to be read in

MDHDZ91 and others added 2 commits September 23, 2022 10:34
added "prDE" to pressure keys in the from_cnv function
@ocefpaf
Copy link
Member

ocefpaf commented Sep 23, 2022

Awesome! Ideally we should add a test for it. Do you have a small sample file that uses prDE?

@MDHDZ91
Copy link
Contributor Author

MDHDZ91 commented Sep 23, 2022 via email

@ocefpaf
Copy link
Member

ocefpaf commented Sep 23, 2022

Attaching a file that uses prDE, since the file was from the EPA I am unsure if it can be made public so ideally we should remove it once the test are done.

I believe attachments don't make it into the comments here when using email. However, we should not use it if we don't have permission. I'll make up one and add to the tests.

Thanks again for the PR!

@ocefpaf ocefpaf merged commit f5a3a00 into pyoceans:main Sep 23, 2022
@ocefpaf ocefpaf mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants