-
Notifications
You must be signed in to change notification settings - Fork 36
Update read.py #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read.py #176
Conversation
update the from_cnv reading options to include "prM" without a space as a key, update the prkey error conditional statements to be able to read files that may have more than 1 key (such as both depth and pressure)
for more information, see https://pre-commit.ci
Do you have an example file that we can add to the tests? I made a small modification to your PR that hopefully will cover more future cases too. |
|
This is a portion of the .cnv in which I have "prM" a =s my key, that you can use a test. |
|
Thanks! I'll add a test as soon as possible. Do you mind checking if a dev install of the library solves ir for you though? I can cut a release as soon as you do. |
|
calling the updated libraries from my git branch solved my issues, it was really that space in "prM" |
update the from_cnv reading options to include "prM" without a space as a key, update the prkey error conditional statements to be able to read files that may have more than 1 key (such as both depth and pressure)