Skip to content

added unit tests and fix for issue #204 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocefpaf merged 4 commits into from
Feb 27, 2024
Merged

added unit tests and fix for issue #204 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22986b3
added unit tests and fix for issue #204
upsonp Feb 22, 2024
16a9fc2
fixed import issue
upsonp Feb 22, 2024
17c1bc8
Update ctd/read.py
upsonp Feb 27, 2024
3c9b3f5
Update test_read.py
upsonp Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ctd/read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,9 @@ def from_cnv(fname):
)
df.index.name = prkey

name = _basename(fname)[1]
if "name" not in metadata:
name = _basename(fname)[1]
metadata["name"] = str(name)

dtypes = {"bpos": int, "pumps": bool, "flag": bool}
for column in df.columns:
Expand All @@ -463,7 +465,6 @@ def from_cnv(fname):
stacklevel=2,
)

metadata["name"] = str(name)
df._metadata = metadata
return df

Expand Down
Loading