fixes and improvements for tidal filter#94
Merged
kthyng merged 8 commits intopyoceans:mainfrom Sep 13, 2023
Merged
Conversation
Collaborator
Author
|
@ocefpaf Can you take a look at this PR? |
ocefpaf
reviewed
Aug 28, 2023
change syntax of number Co-authored-by: Filipe <ocefpaf@gmail.com>
ocefpaf
reviewed
Aug 28, 2023
ocefpaf
reviewed
Sep 5, 2023
Co-authored-by: Filipe <ocefpaf@gmail.com>
Collaborator
Author
|
@ocefpaf Can I merge this? And could you release a new version afterward? |
Collaborator
Author
|
@ocefpaf I'm also happy to do the release myself! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tidal filter isn't working correctly at least in certain cases, but this fixes it and expands some options.