Skip to content

Override leaky env vars#406

Closed
layday wants to merge 40 commits into
pypa:mainfrom
layday:override-leaky-env-vars
Closed

Override leaky env vars#406
layday wants to merge 40 commits into
pypa:mainfrom
layday:override-leaky-env-vars

Conversation

@layday
Copy link
Copy Markdown
Member

@layday layday commented Nov 12, 2021

On top of #361.

layday added 30 commits November 5, 2021 16:54
@layday
build: add BuildSystemTableValidationError to module exports
f8e002f
@layday
multi: use same __all__ style and placement in all modules
632c57c
@layday
main: remove redundant re-export
b160e76 
"build" is the name of the package.
@layday
multi: refactor isolated env
b6b0d20 
* `IsolatedEnv` reworked to subsume env creation logic.

* `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`.

* `ProjectBuilder.from_isolated_env` added to auto-fill init args from
  an isolated env.

* Made `IsolatedEnv` responsible for customising the environ as a
  prelude to fixing pypa#377.  Removed `ProjectBuilder.scripts_dir`.

* `ProjectBuilder`'s @properties made read-only. Mutating the builder
  is not necessary with the addition of
  `ProjectBuilder.from_isolated_env`.
@layday
env: cache min pip version
c84ec7b
@layday
multi: use module names for loggers
da72994 
DRY.
@layday
build: reword docstrings for clarity and style
e22cebb
@layday
build: factor out parsing pyproject.toml and source dir
3aef796 
Fixed passing the absolutised srcdir.
@layday
tests: adapt tests for new env interface
456c722
@layday
build: convert runner callback to protocol for better typing
e784781
@layday
multi: move type aliases and check_dependency to new module to avoi…
e7d4b0a 
…d circular imports
@layday
multi: add distribution types
042f640
@layday
ci: fix typo
5aa5639
@layday
docs: don't evaluate parameter defaults
1e1f0ab 
For example `sys.executable` would have been expanded on RTD.
@layday
docs: evaluate forward references
e6ed295 
This is to get annotations in `TYPE_CHECKING` blocks to show.

We also mustn't import build before sphinx has a chance to.
@layday
docs: document RunnerCallback's __call__ method
3f14e0d
@layday
docs: remove API doc blurb
d4e830b 
There's three modules now which are listed on the sidebar.
@layday
build: remove superfluous type aliases
650ca35
@layday
main: return concrete types from wrappers
a1cb94b
@layday
build: make srcdir read-only
e1ec328
@layday
multi: allow using alternative runners in isolated env
0939a29
@layday
util: mute subprocess output in isolated env
2bf0132
@layday
main: consistently print errors to stderr
7cfe68a
@layday
tests: add from_isolated_env constructor test
ff060dd
@layday
tests: placate flake8
0da9d7d
@layday
tox: bump docs Python to 3.9
0b23940 
This is required to resolve annotations in sphinx which are not
generic at runtime (`os.PathLike`, in particular).
@layday
util: specify type: ignore class
5cfedf6 
Also link to the correct PR.
@layday
docs: show items in the order they are defined
648d765
@layday
env: use cache from stdlib in 3.9 and above
1e07987
@layday
coverage: add TYPE_CHECKING to excludes
9b2b995
@FFY00 FFY00 added the blocked label Nov 15, 2021
@layday layday mentioned this pull request Jan 7, 2022
Closed
This was referenced Jan 17, 2022
Closed
Closed
@adamjstewart
Copy link
Copy Markdown

adamjstewart commented Jan 23, 2022

Fixes #266

@layday
Copy link
Copy Markdown
Member Author

layday commented Jan 23, 2022

It fixes one particular cause of that error. I think that we should provide a better message for when pip can't be found, that's what #266 ought to fix.

@gaborbernat
Copy link
Copy Markdown
Collaborator

gaborbernat commented Jan 25, 2022

@layday shall we close this now, or you want to rebase it?

@layday
Copy link
Copy Markdown
Member Author

layday commented Jan 25, 2022

This is blocked by #361, no point rebasing before #361 is resolved.

@gaborbernat
Copy link
Copy Markdown
Collaborator

gaborbernat commented Jan 25, 2022

This is blocked by #361,

Approved.

@layday
Copy link
Copy Markdown
Member Author

layday commented Jan 27, 2022

Feel free to cherry-pick whatever makes sense.

@layday layday closed this Jan 27, 2022
@salotz-sitx
Copy link
Copy Markdown

salotz-sitx commented Feb 1, 2022

Seeing as #361 isn't going to be merged should this be reopened? Or am I missing what the decision is?

@FFY00
Copy link
Copy Markdown
Member

FFY00 commented Feb 1, 2022

The problem is lack of maintainer time. I was unable to review this in time, so @layday decided to close it. I hope to pick it up in the next few months.

@henryiii
Copy link
Copy Markdown
Contributor

henryiii commented Feb 1, 2022

There's somewhat of a bottleneck waiting on @FFY00 to review #361. I think the plan is still to go with #361, we even had an approval for it.

@salotz-sitx
Copy link
Copy Markdown

salotz-sitx commented Feb 1, 2022

Got it, thank you!

@layday
Copy link
Copy Markdown
Member Author

layday commented Feb 1, 2022

It's nothing personal, just having PRs linger fills me with a weird sort of anxiety.

@salotz-sitx
Copy link
Copy Markdown

salotz-sitx commented Feb 1, 2022

Whatever makes you more productive :) I just wanted to know if I should keep following along or not.

@henryiii
Copy link
Copy Markdown
Contributor

henryiii commented Feb 1, 2022

We can reopen as needed, so they aren't just sitting open. :) I'm also happy to volunteer to rebase as needed. It's just @FFY00 is the most qualified to review.

@salotz-sitx
Copy link
Copy Markdown

salotz-sitx commented Sep 23, 2022

For anyone looking for workarounds coming from the Spack world.

I install Python and all my run time dependencies using Spack but for development tools (like build) I typically just install them with pip in a venv on top of the Spack virtual environment. Installing build alone I get this problem, but build[virtualenv] works for me in this case.

@adamjstewart
Copy link
Copy Markdown

adamjstewart commented Sep 23, 2022

Spack should no longer have this issue in the latest release. I added a patch to unset PYTHONPATH to avoid this issue: spack/spack#28562

@adamjstewart
Copy link
Copy Markdown

adamjstewart commented Feb 3, 2023

Was this issue ever fixed in main or is a patch still needed?

@layday
Copy link
Copy Markdown
Member Author

layday commented Feb 3, 2023

Still needed.

@adamjstewart
Copy link
Copy Markdown

adamjstewart commented Feb 3, 2023

According to #470, the recommended way to bootstrap build is to install it from a wheel. How do I patch a wheel?

@adamjstewart
Copy link
Copy Markdown

adamjstewart commented Feb 3, 2023

Or is there a way to use build to build itself?

@layday
Copy link
Copy Markdown
Member Author

layday commented Feb 3, 2023

You can run build from source to build build with build.

@adamjstewart adamjstewart mentioned this pull request Feb 3, 2023
Closed
@henryiii
Copy link
Copy Markdown
Contributor

henryiii commented Feb 3, 2023 •
edited
Loading

#361 was replaced by #537, so can't this be redone on top of that? I can't actually tell anymore what this PR was changing due to 361 and this not being regularly rebased (merge commits are evil).

@layday
Copy link
Copy Markdown
Member Author

layday commented Feb 3, 2023

These are the two changes unique to this PR:

@adamjstewart
Copy link
Copy Markdown

adamjstewart commented Feb 3, 2023

The specific bug we're facing is #266, so once #266 is solved we'll no longer need to patch. This patch was sufficient for us to solve the issue, but I'm not sure how hacky that is. It's also outdated, see spack/spack#35326 for my latest patch.

@layday layday deleted the override-leaky-env-vars branch March 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 FFY00 left review comments

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat is a code owner

Assignees

No one assigned

Labels

blocked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@layday @adamjstewart @gaborbernat @salotz-sitx @FFY00 @henryiii