Fix test_executable_missing_post_creation for Python 3.11, PyPy#459
Merged
Conversation
As a result of python/cpython#31034, venv now calls sysconfig.get_paths. This messes up the mock call count. The change to using Signature.bind isn't strictly necessary, but fixes the initial symptom (since venv calls sysconfig.get_paths without kwargs). This also means we can use sysconfig.get_paths however we want.
hauntsaninja
requested review from
FFY00,
gaborbernat,
henryiii and
layday
as code owners
Contributor
Author
|
cc @hroncok |
henryiii
approved these changes
Apr 16, 2022
Contributor
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
LGTM. The PyPy 3.7 Windows builds broke 4-11 days ago; guessing it might be the PyPy 7.3.9 release. Look like pytest-rerun-failures is breaking it. The other libraries I checked haven't had releases in that time frame.
hroncok
reviewed
Apr 16, 2022
Member
|
I feel like this is a lot of unnecessary work just to test that a file which does not exist will produce an error. Can we mock |
Member
|
I suppose we can also get rid of the skip decorator since the same is true for Python 3.11. |
hauntsaninja
changed the title
Member
|
Forgot to change the commit message again 😣 |
Member
|
Wait, I thought I was the was the one merging this, perhaps you were too fast 😅 |
Member
|
Yeah, I forgot too. |
Member
|
Yeah, no worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of python/cpython#31034,
venv now calls sysconfig.get_paths. This messes up the mock call
count.
The change to using Signature.bind isn't strictly necessary, but fixes
the initial symptom (since venv calls sysconfig.get_paths without
kwargs). This also means we can use sysconfig.get_paths however we want.