MNT: remove workaround for 3.14b1 #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
requested review from
FFY00,
gaborbernat,
henryiii and
layday
as code owners
layday
reviewed
Dec 8, 2025
This is broken with cpython main which removed the color keyword argument to HelperFormatter in python/cpython#142274
tacaswell
force-pushed
the
mnt/remove_314b1_workaround
branch
from
f26a554 to
792d9ec
Compare
henryiii
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broken with cpython main which removed the color keyword argument to HelperFormatter in python/cpython#142274
I have not dug into whatthis was working around to verify that it is safe to remove and trusted @henryiii 's comment. If it is not, then this should be adjusted to have an upper bound of the Python version.