Return install record mismatches from install()#328
Open
dimbleby wants to merge 1 commit into
Open
Conversation
dimbleby
force-pushed
the
install-record-validation
branch
2 times, most recently
from
ee7eebf to
a3d7679
Compare
install() now returns a list of (source_record, installed_record) tuples for files whose hash or size differs from the wheel's RECORD. Callers that don't care can ignore the return value (previously None). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dimbleby
force-pushed
the
install-record-validation
branch
from
3fd787d to
5225ec8
Compare
Member
|
@pradyunsg I would like your input on that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
have
install()return a list of (source_record, installed_record) tuples for files whose hash or size differs from the wheel'sRECORD. Callers that don't care can ignore the return value (previously None).Alternative approach to #327, allowing installers to detect (most) errors in only a single pass over large files. They would
validate_record(validate_contents=False)install()and pay attention to reported mismatches.This is not perfect
RECORDthat is wrong for scripts gets missed, because installer rewrites scripts during installvalidate_record()RECORDthat uses an algorithm other than one of the blessed few is not checkedvalidate_record()is still available.Destination.hash_algorithm, but it would be a breaking change to pass this through more cleanly as a parameter.But it covers most things in an efficient way.
Maintainers will need to take a view on whether this is a reasonable set of trade-offs or not.