Skip to content

Update link that was failing on CI#1507

Closed
willingc wants to merge 2 commits into
mainfrom
willingc-patch-1
Closed

Update link that was failing on CI#1507
willingc wants to merge 2 commits into
mainfrom
willingc-patch-1

Conversation

@willingc
Copy link
Copy Markdown
Contributor

@willingc willingc commented Feb 22, 2024

Comment thread source/tutorials/installing-packages.rst Outdated
@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Feb 22, 2024

(tutorials/installing-packages: line  444) broken    https://stackoverflow.com/questions/14637979/how-to-permanently-set-path-on-linux-unix/14638025#14638025 - 403 Client Error: Forbidden for url: https://stackoverflow.com/questions/14637979/how-to-permanently-set-path-on-linux-unix/14638025

Extend https://github.com/pypa/packaging.python.org/blob/4c86169/source/conf.py#L102-L110 instead. They probably just blocked all GitHub's IP addresses or something.

The link to stack overflow doesn't add much value. I'm going to remove the link.
@willingc
Copy link
Copy Markdown
Contributor Author

Thanks for the review and suggestion @webknjaz. I've opted to remove the link to SO since it doesn't add much additional value.

@willingc willingc requested a review from webknjaz February 22, 2024 01:50
@webknjaz
Copy link
Copy Markdown
Member

Why do you think it doesn't?

@webknjaz webknjaz requested a review from theacodes February 22, 2024 13:44
@webknjaz
Copy link
Copy Markdown
Member

@dukecat0 @jwodder @theacodes since you were the ones to touch/add that link, do you have any opinion on keeping or dropping it?

@webknjaz webknjaz requested a review from dukecat0 February 22, 2024 13:46
@dukecat0
Copy link
Copy Markdown
Member

I personally prefer keeping it as a quick reference for beginners, who are the main audience of this tutorial.

@webknjaz
Copy link
Copy Markdown
Member

Yeah, that's my concern as well. I prefer keeping the reference and ignoring the link instead.

@willingc
Copy link
Copy Markdown
Contributor Author

Sounds good. I'll add back the link.

@willingc willingc closed this Feb 26, 2024
@willingc
Copy link
Copy Markdown
Contributor Author

Close and replace with #1510 to ignore stack overflow for linkchecks

@willingc willingc deleted the willingc-patch-1 branch February 26, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants