Document the JSON schema of direct_url.json#1512
Merged
Conversation
Member
|
@edgarrmondragon FYI CI failed. |
brettcannon
reviewed
Feb 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
webknjaz
approved these changes
Feb 29, 2024
edgarrmondragon
added a commit
to edgarrmondragon/pep610
that referenced
this pull request
Mar 1, 2024
Will merge whatever pypa/packaging.python.org#1512 ends up with, even if it's not accepted in the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a JSON schema for the structure of
direct_url.json.Based on https://github.com/edgarrmondragon/pep610/blob/41a39253521637e85f364f60d1106c25dfa03d02/tests/fixtures/direct_url.schema.json with some changes to make it more accurate:
deprecatedcan be used forarchive_info.hash.archive_info.hashto actually accomodate valid algorithm names. e.g.md5=...wouldn't have been valid before.See the discuss thread for more context.
Relevant docs preview: https://python-packaging-user-guide--1512.org.readthedocs.build/en/1512/specifications/direct-url-data-structure/#json-schema
📚 Documentation preview 📚: https://python-packaging-user-guide--1512.org.readthedocs.build/en/1512/