Rename the project to pyproject-hooks and trim scope#151
Merged
Conversation
This more clearly indicates the files that will eventually become importable.
This functionality does not need to be maintained after this project is renamed.
This template is not going to be necessary since this project will have dropped these bits of functionality.
This more accurately reflects what this project is for.
This is a better name for the functionality provided by this class.
This makes the imports for this package cleaner.
This makes it clearer that this sub-package is intended to be a private implementation detail.
This Python version is post-EOL.
Member
Author
|
There are a few more "obvious" improvements, like moving to I suggest that we make those improvements in follow ups. |
This was referenced Oct 30, 2022
Secrus
reviewed
Oct 30, 2022
| quiet_subprocess_runner, | ||
| ) | ||
|
|
||
| __version__ = '0.13.0' |
Member
There was a problem hiding this comment.
Wouldn't this call for either a major version bump or versioning reset, since this practically makes this a new project from an end-user perspective?
Member
There was a problem hiding this comment.
I don't think it's required, because with the name change there's no risk of unwittingly upgrading. But I'd be happy enough to call it 1.0 now that we're cutting off the deprecated bits of API.
takluyver
reviewed
Oct 31, 2022
Member
|
Thanks @pradyunsg ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #136
Closes #142, by removing the functionality it is requesting changes to.
Closes #91, by removing the functionality that it is tracking removal of.
Closes #49, by removing the functionality it is requesting changes to.
This is the first step, listed in #136 (comment).