Add pyproject toml#105
Closed
pganssle wants to merge 2 commits into
Closed
Conversation
These are the default for tox anyway, and for some reason having them in place combined with `isolated_build = True` causes an error, so best to remove it.
pganssle
force-pushed
the
add_pyproject_toml
branch
from
61c6865 to
ee4dfa8
Compare
Adds a `pyproject.toml` file and enables build isolation in tox.
pganssle
force-pushed
the
add_pyproject_toml
branch
from
ee4dfa8 to
973fc01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79
This is a version of this that I think is less controversial than #101, as it does not pin to a specific version of
setuptoolsorwheel.The basepython declarations need to be removed in order to enable build isolation in
toxfor some reason. When I have time I can dig into that and see if it's a bug intox.