Skip to content

Drop support for EOL Python 2#116

Merged
di merged 2 commits into
pypa:masterfrom
hugovk:rm-2
May 5, 2020
Merged

Drop support for EOL Python 2#116
di merged 2 commits into
pypa:masterfrom
hugovk:rm-2

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented May 4, 2020

Fixes #115.

@hugovk hugovk mentioned this pull request May 4, 2020
@di
Copy link
Copy Markdown
Member

di commented May 4, 2020

If I understand #114 correctly, we can also make this change:

- check-manifest --ignore 'tox.ini,tests,tests/**'
+ check-manifest --ignore 'tox.ini,tests/**'

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented May 5, 2020

If I understand #114 correctly, we can also make this change:

- check-manifest --ignore 'tox.ini,tests,tests/**'
+ check-manifest --ignore 'tox.ini,tests/**'

Updated in a4117c8.

With check-manifest 0.41, the former passes and the latter fails:

$ check-manifest --version
check-manifest version 0.41
$ check-manifest --ignore 'tox.ini,tests,tests/**'
lists of files in version control and sdist match
$ check-manifest --ignore 'tox.ini,tests/**'
lists of files in version control and sdist do not match!
missing from sdist:
  tests
$

With check-manifest 0.42, both pass:

$ check-manifest --version
check-manifest version 0.42
$ check-manifest --ignore 'tox.ini,tests,tests/**'
lists of files in version control and sdist match
$ check-manifest --ignore 'tox.ini,tests/**'
lists of files in version control and sdist match

@di di merged commit 9573ed1 into pypa:master May 5, 2020
@di
Copy link
Copy Markdown
Member

di commented May 5, 2020

Thanks all!

@hugovk hugovk deleted the rm-2 branch May 5, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python 2.7 support

5 participants