Skip to content

Move version to declarative config#1687

Merged
pganssle merged 2 commits into
masterfrom
feature/version-in-cfg
Feb 22, 2019
Merged

Move version to declarative config#1687
pganssle merged 2 commits into
masterfrom
feature/version-in-cfg

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Feb 17, 2019

This change moves the setuptools version to declarative config. In order to accomplish this, the bump2version config had to be moved to .bumpversion.cfg.

I'm creating this PR in light of #1679, which conflicts with this change, to highlight the direction that I'd prefer the setuptools project should move.

@jaraco jaraco changed the title This change moves the setuptools version to declarative config. In order to accomplish this, the bump2version config had to be moved to .bumpversion.cfg. Move version to declarative config Feb 17, 2019
@pganssle
Copy link
Copy Markdown
Member

@jaraco Will bumpversion update the setup.cfg file for us?

Is this a bug in bumpversion? Can we fix this upstream in bumpversion?

@pganssle
Copy link
Copy Markdown
Member

Upstream issue is peritus/bumpversion#198 I guess.

@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Feb 17, 2019

Sadly, the peritus fork doesn't support annotated tags, so I recommend using bump2version, where I filed the ticket today.

@pganssle
Copy link
Copy Markdown
Member

This is fine with me, we can remove the bumpversion configuration when this is fixed in bump2version.

@techtonik

This comment has been minimized.

@pganssle
Copy link
Copy Markdown
Member

pganssle commented Sep 7, 2019

@techtonik I would ask you to please have more respect when interacting with others on this issue tracker. You have recently made many negative, low-effort comments in several issues and PRs which are not constructive and some of which are simply off-topic. Please try to assume good faith from everyone involved in the project and keep your criticisms constructive.

In this instance, this PR is not an advertisement of best practices, just an improvement to the workflow of setuptools. We already had a dependency on bump2version and it has worked very well for us, to date, this is just moving more of our configuration into the declarative file.

@techtonik
Copy link
Copy Markdown
Contributor

@pganssle what is wrong with respecting an opinion in a non-personal way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants