Skip to content

Enable logging through Python logging module#2974

Merged
jaraco merged 2 commits into
mainfrom
feature/logging
Dec 28, 2021
Merged

Enable logging through Python logging module#2974
jaraco merged 2 commits into
mainfrom
feature/logging

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Dec 26, 2021

Summary of changes

Closes #2973. Closes #2023.

Pull Request Checklist

Copy link
Copy Markdown
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a very nice move!

The CI errors seem to be just a hiccup, and pass on the second run

Comment thread setuptools/__init__.py
@jaraco jaraco closed this Dec 28, 2021
@jaraco jaraco reopened this Dec 28, 2021
@jaraco jaraco merged commit 312e315 into main Dec 28, 2021
@jaraco jaraco deleted the feature/logging branch December 28, 2021 21:25
Comment thread setuptools/logging.py
out_handler.addFilter(_not_warning)
handlers = err_handler, out_handler
logging.basicConfig(
format="{message}", style='{', handlers=handlers, level=logging.DEBUG)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why default level is DEBUG instead of INFO or WARNING?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacement needed for distutils.log Recommended practice for logging in plugins?

3 participants