Work around typing issue from more_itertools#5208
Open
Work around typing issue from more_itertools#5208
Conversation
Contributor
Author
|
The diffcov failure is spurious: the current diffcov configuration will never see top-level imports. Unfortunately, when I try to fix it, I hit pytest-dev/pytest-cov#740. The simplest thing is probably just to ignore the diffcov failure on this PR. |
Contributor
Author
|
more-itertools/more-itertools#1144 and a more-itertools release might obviate the need for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Running the tests with the latest versions of the test dependencies will fail due to an issue in more_itertools: more-itertools/more-itertools#1143.
For now, to unbreak CI, I'm adding a runtime cast to avoid the type checking issue.
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)