Skip to content

Conversation

@tqa236
Copy link
Contributor

@tqa236 tqa236 commented Oct 25, 2024

I divide the MR into 2 commits:

  • The first one sets up ruff and its config
  • The second one fixes all sensible auto-fix errors

If you want to check with rules that ruff auto-fix, please checkout to the first commit, change fix = false and run pre-commit run ruff --all-files

I make the current config based on my experience, please feel free to reclassify the rules to "won't fix" or "to do"

  • Closes #xxxx
  • Tests added
  • Fully documented, including history.rst for all changes and api/*.rst for new API

@codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (efa3faa) to head (6a38287).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
+ Coverage   96.40%   96.50%   +0.09%     
==========================================
  Files          20       20              
  Lines        1810     1830      +20     
==========================================
+ Hits         1745     1766      +21     
+ Misses         65       64       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snowman2 snowman2 merged commit 5e39d2a into pyproj4:main Oct 30, 2024
@snowman2
Copy link
Member

Thanks @tqa236 👍

@tqa236 tqa236 deleted the setup-ruff branch October 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants