Skip to content

Include LICENSE.md in sdist tarball#598

Merged
fritzo merged 4 commits into
pyro-ppl:masterfrom
xhochy:patch-1
Oct 28, 2022
Merged

Include LICENSE.md in sdist tarball#598
fritzo merged 4 commits into
pyro-ppl:masterfrom
xhochy:patch-1

Conversation

@xhochy
Copy link
Copy Markdown
Contributor

@xhochy xhochy commented Oct 25, 2022

This ensures that the license is shipped in the sdist tarball on PyPI.

@jakirkham
Copy link
Copy Markdown

Think we can add this to setup.cfg

Comment thread setup.cfg
Comment on lines +1 to +3
[metadata]
# This includes the license file(s) in the wheel.
license_files = LICENSE.md
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also work for sdists

pypa/setuptools#1536

@fritzo
Copy link
Copy Markdown
Member

fritzo commented Oct 28, 2022

Hi @xhochy thanks for the fix. Could you merge in master to get the fix from #599 that's causing the CI failure? (I'm not sure how to do that as a maintainer from the github web ui)

@xhochy
Copy link
Copy Markdown
Contributor Author

xhochy commented Oct 28, 2022

Hi @xhochy thanks for the fix. Could you merge in master to get the fix from #599 that's causing the CI failure? (I'm not sure how to do that as a maintainer from the github web ui)

Done.

@fritzo fritzo merged commit 1b9b68d into pyro-ppl:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants